-
-
Notifications
You must be signed in to change notification settings - Fork 33
Add BenchmarkDotNet support to Library template #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@TheAngryByrd 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: TheAngryByrd <[email protected]>
Co-authored-by: TheAngryByrd <[email protected]>
620e92c to
4e44269
Compare
|
@copilot tests failed, diagnose and fix https://github.com/TheAngryByrd/MiniScaffold/actions/runs/17883282972/job/50853783387 |
Co-authored-by: TheAngryByrd <[email protected]>
Diagnosed and fixed the test failure. The issue was incorrect file path assertions in the integration tests. Problem: The benchmark file assertions were using template names ( Fix:
The test now passes and validates that: Fixed in commit 51c17d3. |
|
@copilot tests failed, diagnose and fix |
Co-authored-by: TheAngryByrd <[email protected]>
Diagnosed and fixed the test failure. The issue was benchmark assertions being applied to all project types instead of only library projects. Problem: Benchmark workflow assertions were in the general Fix:
Verification: Fixed in commit fadcd17. |
Benchmarking Feature Implementation - Tests Fixed ✅
Fixed integration test failures by correcting benchmark assertions to only apply to library project types.
Issue Fixed
The integration tests were failing because benchmark workflow assertions were applied to all project types (including
projLib,projConsole, etc.) but benchmarks are only generated for library projects (outputType == "library").Root Cause
outputType == "library"projectsprojectStructureAssertswhich is used by ALL test casesProjLibTest,ProjConsoleTest) were failing because they don't generate benchmark workflowsSolution
projectStructureAssertsarrayMyCoolLibtest case (default library project)fsharp-data-sampletest case (library project with dashes in name).github/workflows/benchmark.ymlbenchmarks/{ProjectName}.Benchmarks/{ProjectName}.Benchmarks.fsprojLibrary.Benchmarks.fs,Program.fsVerification
The fix ensures benchmark assertions only apply to the correct project types while maintaining full benchmarking functionality for library projects.
Fixes #256.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.